From 1d540f7d371ce222bca80e0f27953486d43ee796 Mon Sep 17 00:00:00 2001
From: Finn M Glas <finnmglas@gmail.com>
Date: Sat, 23 May 2020 12:37:15 +0200
Subject: [PATCH] Hide the select button for the already selected theme

And reorder themes, Finn's theme on top, as it is the default ^^
---
 .../com/finnmglas/launcher/MainActivity.kt    |  2 +-
 .../finnmglas/launcher/SettingsActivity.kt    | 17 ++++++
 .../res/layout/fragment_settings_theme.xml    | 61 ++++++++++---------
 3 files changed, 50 insertions(+), 30 deletions(-)

diff --git a/app/src/main/java/com/finnmglas/launcher/MainActivity.kt b/app/src/main/java/com/finnmglas/launcher/MainActivity.kt
index a7278ab..bab709e 100644
--- a/app/src/main/java/com/finnmglas/launcher/MainActivity.kt
+++ b/app/src/main/java/com/finnmglas/launcher/MainActivity.kt
@@ -128,7 +128,7 @@ class MainActivity : AppCompatActivity(),
     /** Touch- and Key-related functions to start activities */
 
     override fun onKeyDown(keyCode: Int, event: KeyEvent?): Boolean {
-        if (keyCode == KeyEvent.KEYCODE_BACK) if (settingsIconShown) hideSettingsIcon()
+        if (keyCode == KeyEvent.KEYCODE_BACK) { if (settingsIconShown) hideSettingsIcon() }
         else if (keyCode == KeyEvent.KEYCODE_VOLUME_UP) launchApp(volumeUpApp, this)
         else if (keyCode == KeyEvent.KEYCODE_VOLUME_DOWN) launchApp(volumeDownApp, this)
         return true
diff --git a/app/src/main/java/com/finnmglas/launcher/SettingsActivity.kt b/app/src/main/java/com/finnmglas/launcher/SettingsActivity.kt
index 9d8f27e..ee3d6b2 100644
--- a/app/src/main/java/com/finnmglas/launcher/SettingsActivity.kt
+++ b/app/src/main/java/com/finnmglas/launcher/SettingsActivity.kt
@@ -22,6 +22,8 @@ import androidx.viewpager.widget.ViewPager
 import com.finnmglas.launcher.ui.main.SectionsPagerAdapter
 import com.google.android.material.tabs.TabLayout
 import kotlinx.android.synthetic.main.activity_settings.*
+import kotlinx.android.synthetic.main.activity_settings.container
+import kotlinx.android.synthetic.main.fragment_settings_theme.*
 import java.io.FileNotFoundException
 import java.io.IOException
 
@@ -52,6 +54,21 @@ class SettingsActivity : AppCompatActivity() {
         val tabs: TabLayout = findViewById(R.id.tabs)
         tabs.setupWithViewPager(viewPager)
 
+        // Hide 'select' button for the selected theme
+        tabs.addOnTabSelectedListener(object : TabLayout.OnTabSelectedListener {
+            override fun onTabSelected(tab: TabLayout.Tab) {
+                if (tab == tabs.getTabAt(1 )) {
+                    when (getSavedTheme(container!!.context)) {
+                        "dark" -> select_theme_dark.visibility = View.INVISIBLE
+                        "finn" -> select_theme_finn.visibility = View.INVISIBLE
+                        "custom" -> select_theme_custom.visibility = View.INVISIBLE
+                    }
+                }
+            }
+            override fun onTabUnselected(tab: TabLayout.Tab) {}
+            override fun onTabReselected(tab: TabLayout.Tab) {}
+        })
+
         // As older APIs somehow do not recognize the xml defined onClick
         close_settings.setOnClickListener() { finish() }
     }
diff --git a/app/src/main/res/layout/fragment_settings_theme.xml b/app/src/main/res/layout/fragment_settings_theme.xml
index b3f79d5..d909167 100644
--- a/app/src/main/res/layout/fragment_settings_theme.xml
+++ b/app/src/main/res/layout/fragment_settings_theme.xml
@@ -22,35 +22,6 @@
             android:layout_height="wrap_content"
             android:orientation="vertical">
 
-            <androidx.cardview.widget.CardView
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:layout_marginBottom="10sp"
-                app:cardCornerRadius="8dp">
-
-                <androidx.constraintlayout.widget.ConstraintLayout
-                    android:layout_width="match_parent"
-                    android:layout_height="match_parent">
-
-                    <ImageView
-                        android:layout_width="match_parent"
-                        android:layout_height="match_parent"
-                        android:adjustViewBounds="true"
-                        android:scaleType="fitXY"
-                        app:srcCompat="@drawable/dark_theme" />
-
-                    <Button
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:onClick="chooseDarkTheme"
-                        android:text="@string/settings_select_theme"
-                        android:textAllCaps="false"
-                        app:layout_constraintBottom_toBottomOf="parent"
-                        app:layout_constraintEnd_toEndOf="parent" />
-                </androidx.constraintlayout.widget.ConstraintLayout>
-
-            </androidx.cardview.widget.CardView>
-
             <androidx.cardview.widget.CardView
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
@@ -70,6 +41,7 @@
                         app:srcCompat="@drawable/finnmglas_theme" />
 
                     <Button
+                        android:id="@+id/select_theme_finn"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:onClick="chooseFinnTheme"
@@ -82,6 +54,36 @@
 
             </androidx.cardview.widget.CardView>
 
+            <androidx.cardview.widget.CardView
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:layout_marginBottom="10sp"
+                app:cardCornerRadius="8dp">
+
+                <androidx.constraintlayout.widget.ConstraintLayout
+                    android:layout_width="match_parent"
+                    android:layout_height="match_parent">
+
+                    <ImageView
+                        android:layout_width="match_parent"
+                        android:layout_height="match_parent"
+                        android:adjustViewBounds="true"
+                        android:scaleType="fitXY"
+                        app:srcCompat="@drawable/dark_theme" />
+
+                    <Button
+                        android:id="@+id/select_theme_dark"
+                        android:layout_width="wrap_content"
+                        android:layout_height="wrap_content"
+                        android:onClick="chooseDarkTheme"
+                        android:text="@string/settings_select_theme"
+                        android:textAllCaps="false"
+                        app:layout_constraintBottom_toBottomOf="parent"
+                        app:layout_constraintEnd_toEndOf="parent" />
+                </androidx.constraintlayout.widget.ConstraintLayout>
+
+            </androidx.cardview.widget.CardView>
+
             <androidx.cardview.widget.CardView
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
@@ -100,6 +102,7 @@
                         app:srcCompat="@drawable/custom_theme" />
 
                     <Button
+                        android:id="@+id/select_theme_custom"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:onClick="chooseCustomTheme"