From 75b22400c5eee341938df2bf3aac68e8543f1eb0 Mon Sep 17 00:00:00 2001
From: Josia Pietsch <git@jrpie.de>
Date: Sat, 15 Mar 2025 17:24:19 +0100
Subject: [PATCH 1/2] try to fix #125

---
 app/src/main/res/layout/list_apps_row.xml              | 7 +++++--
 app/src/main/res/layout/list_apps_row_variant_grid.xml | 3 ++-
 app/src/main/res/layout/list_apps_row_variant_text.xml | 2 +-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/app/src/main/res/layout/list_apps_row.xml b/app/src/main/res/layout/list_apps_row.xml
index 85ce5e6..0229195 100644
--- a/app/src/main/res/layout/list_apps_row.xml
+++ b/app/src/main/res/layout/list_apps_row.xml
@@ -15,18 +15,21 @@
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
+        tools:src="@mipmap/ic_launcher_round"
         tools:ignore="ContentDescription" />
 
     <TextView
         android:id="@+id/list_apps_row_name"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        android:layout_marginStart="60sp"
+        android:layout_marginStart="20sp"
         android:gravity="start"
         android:text=""
         android:textSize="20sp"
+        tools:text="@string/app_name"
         app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintStart_toEndOf="@id/list_apps_row_icon"
+        app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file
diff --git a/app/src/main/res/layout/list_apps_row_variant_grid.xml b/app/src/main/res/layout/list_apps_row_variant_grid.xml
index 1a9058c..ee57c45 100644
--- a/app/src/main/res/layout/list_apps_row_variant_grid.xml
+++ b/app/src/main/res/layout/list_apps_row_variant_grid.xml
@@ -15,6 +15,7 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
+        tools:src="@mipmap/ic_launcher_round"
         tools:ignore="ContentDescription" />
 
     <TextView
@@ -25,7 +26,7 @@
         android:paddingTop="5dp"
         android:text=""
         android:textSize="11sp"
-        tools:text="some app"
+        tools:text="@string/app_name"
         app:layout_constraintTop_toBottomOf="@id/list_apps_row_icon"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
diff --git a/app/src/main/res/layout/list_apps_row_variant_text.xml b/app/src/main/res/layout/list_apps_row_variant_text.xml
index 700dd7c..cba4672 100644
--- a/app/src/main/res/layout/list_apps_row_variant_text.xml
+++ b/app/src/main/res/layout/list_apps_row_variant_text.xml
@@ -32,6 +32,6 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent"
-        tools:text="some app" />
+        tools:text="@string/app_name" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file

From 72f9c0595f36debc74d713ed7226871d6470b4e3 Mon Sep 17 00:00:00 2001
From: Josia Pietsch <git@jrpie.de>
Date: Sat, 15 Mar 2025 19:23:44 +0100
Subject: [PATCH 2/2] handle MotionEvent.ACTION_CANCEL in TouchGestureDetector
 (see #126)

---
 .../launcher/ui/TouchGestureDetector.kt       | 24 +++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/de/jrpie/android/launcher/ui/TouchGestureDetector.kt b/app/src/main/java/de/jrpie/android/launcher/ui/TouchGestureDetector.kt
index 1c05d54..74b8351 100644
--- a/app/src/main/java/de/jrpie/android/launcher/ui/TouchGestureDetector.kt
+++ b/app/src/main/java/de/jrpie/android/launcher/ui/TouchGestureDetector.kt
@@ -87,24 +87,40 @@ class TouchGestureDetector(
     }
 
     private var paths = HashMap<Int, PointerPath>()
-    private var gestureIsLongClick = false
+
+    /* Set when
+     *  - the longPressHandler has detected this gesture as a long press
+     *  - the gesture was cancelled by MotionEvent.ACTION_CANCEL
+     * In any case, the current gesture should be ignored by further detection logic.
+     */
+    private var cancelled = false
 
     private var lastTappedTime = 0L
     private var lastTappedLocation: Vector? = null
 
     fun onTouchEvent(event: MotionEvent) {
+
+        if (event.actionMasked == MotionEvent.ACTION_CANCEL) {
+            synchronized(this@TouchGestureDetector) {
+                cancelled = true
+            }
+        }
+
         val pointerIdToIndex =
             (0..<event.pointerCount).associateBy { event.getPointerId(it) }
 
         if (event.actionMasked == MotionEvent.ACTION_DOWN) {
             synchronized(this@TouchGestureDetector) {
                 paths = HashMap()
-                gestureIsLongClick = false
+                cancelled = false
             }
             longPressHandler.postDelayed({
                 synchronized(this@TouchGestureDetector) {
+                    if (cancelled) {
+                        return@postDelayed
+                    }
                     if (paths.entries.size == 1 && paths.entries.firstOrNull()?.value?.isTap() == true) {
-                        gestureIsLongClick = true
+                        cancelled = true
                         Gesture.LONG_CLICK.invoke(context)
                     }
                 }
@@ -142,7 +158,7 @@ class TouchGestureDetector(
                 // if the long press handler is still running, kill it
                 longPressHandler.removeCallbacksAndMessages(null)
                 // if the gesture was already detected as a long click, there is nothing to do
-                if (gestureIsLongClick) {
+                if (cancelled) {
                     return
                 }
             }